Remove swsssdk from rules and image.#11469
Conversation
|
Remove swsssdk from rules first, if UT passed, will remove from image later. |
|
/azp run Azure.sonic-buildimage |
|
Pull request contains merge conflicts. |
|
|
liuh-80
force-pushed
the
dev/liuh/update-rules
branch
from
3c2596e to
81e9770
Compare
rules/docker-config-engine.mk
Outdated
There was a problem hiding this comment.
Database container depends on redis and redis-dump-load
And after remove SWSSSDK_PY2, the indirect depency also been removed, so some test case failed.
There was a problem hiding this comment.
Does this removal also deprecate the redis-dump-load functionality?
What if users still want to use redis-dump-load?
There was a problem hiding this comment.
redis-dump-load
It's been porting to sonic_py_common:
https://github.com/sonic-net/sonic-buildimage/blob/b1102ad91344669072f7769baef693bd18365984/src/sonic-py-common/sonic_py_common/sonic_db_dump_load.py
There was a problem hiding this comment.
Our container does not have redis-dump. We have include this change: #12185
Is there other changes that we are missing?
There was a problem hiding this comment.
Looks like it is missing the entry script:
ls /usr/local/bin/redis-dump
There was a problem hiding this comment.
Looks like we are using sonic-db-dump instead of redis-dump now.
Are they basically the same thing?
Are we removing redis-dump?
There was a problem hiding this comment.
I understand now. sonic-db-dump-load is built on top of redis-dump-load. So it needs redis-dump-load as dependency. Currently, for sonic_py_common python3 package, it does not list redis-dump-load as dependency. And hence sonic-db-dump-load doesn't work. This needs to be fixed.
There was a problem hiding this comment.
@mint570, may I know how you found this issue, some command failed or errro in syslog? I will create a sonic-mgmt test case to prevent this happen again, so need understand the break scenario.
There was a problem hiding this comment.
I just called sonic-db-dump in the container, it failed with the redisdl import.
(Initially I was looking for redis-dump, but there is no such tool in the container.)
|
|
liuh-80
force-pushed
the
dev/liuh/update-rules
branch
from
5e09524 to
1e621d2
Compare
liuh-80
changed the title
|
This PR need wait for 3 vendor side change complete first. |
|
Will check if can move some change which does not depend on vender code to another PR. |
|
WIll fix merge conflict and update soon. |
4 participants
Why I did it
To deprecate swsssdk, remove all dependency to it.
How I did it
Remove swsssdk from rules and build image scripts.
How to verify it
Pass all UT and E2E test case
Which release branch to backport (provide reason below if selected)
Description for the changelog
Remove swsssdk from rules and build image scripts.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)